Skip to content

Fix acl list command showing acls associated to factoids as unused #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
semper-lux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix acl list command showing acls associated to factoids as unused #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/db_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from bot.config import plugin_config_command
from bot.reactions import get_reaction
from plugins.bot_manager import PluginConverter
from plugins.factoids import Factoid
import util.db
from util.discord import CodeBlock, Inline, PlainItem, Typing, UserError, chunk_messages, format

Expand Down Expand Up @@ -142,6 +143,10 @@ async def acl_list(ctx: Context) -> None:
stmt = select(bot.acl.ActionPermissions.acl)
for acl in (await session.execute(stmt)).scalars():
used.add(acl)
stmt = select(Factoid.flags)
for flag in (await session.execute(stmt)).scalars():
if flag is not None:
used.add(flag.get("acl"))
output = "ACLs: {}".format(", ".join(format("{!i}", name) for name in acls if name in used))
if len(acls - used):
output += "\nUnused: {}".format(", ".join(format("{!i}", name) for name in acls if name not in used))
Expand Down