-
Notifications
You must be signed in to change notification settings - Fork 16
Toggle the new Android prop diffing mechanism for components (0.78.0) #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.78.0-discord
Are you sure you want to change the base?
Toggle the new Android prop diffing mechanism for components (0.78.0) #69
Conversation
There are some changes that are part of https://github.com/discord/react-native/pull/65/files, which trigger some changes in the feature flags after running |
Hm, actually i don't think we use Would that work for you as well, or did you want to introduce a new feature flag? I am not sure what all of those changes are, maybe its okay to add them |
For this bug here: 20250527_202152.mp4How did you get into that state? |
@hannomargelo The issue is introduced by enabling the feature flag I cherry picked the changes from 0.79 in this branch and tested the fix in both discord and the react-native fork:
Regarding #69 (comment). |
Summary:
The PR for branch 0.78.2 is #68.
The feature flag is supported in react-native 0.79 and requires cherrypicking the following commits from David Vacca:
Enables feature flag enablePropsUpdateReconciliationAndroid to fix https://app.asana.com/1/236888843494340/project/1199705967702853/task/1209601835367711?focus=true
More info at facebook#45551 and https://github.com/discord/react-native/blob/e0702345591cb461e196aabd8be0bf51839a2df3/packages/react-native/scripts/featureflags/README.md
Changelog:
This diffs toggles the new Android prop diffing mechanism for components
Test Plan:
Regressions from previous PR #61 are fixed by cherry picking the above commits.
Branch 0.78:
After cherry-picking commits:
Discord:
20250527_202152.mp4
20250527_202926.mp4