Add some missing interfaces; alter handling of missing public_key#16
Open
strix-technica wants to merge 5 commits intodisqus:masterfrom
Open
Add some missing interfaces; alter handling of missing public_key#16strix-technica wants to merge 5 commits intodisqus:masterfrom
public_key#16strix-technica wants to merge 5 commits intodisqus:masterfrom
Conversation
added 4 commits
August 10, 2014 16:37
Some API calls (notably posts.create with certain args like ip_address) will not work as expected if both public_key and secret_key are passed, so don't complain if only secret key is provided.
Collaborator
|
@strix-technica Seems that you've broken tests. :) |
Author
|
Well, that was embarrassing. I've fixed it, tested it with Travis on my own fork, and it appears to be good. (And if I read this right, that fix automatically got included in the pull request and Travis has already run and passed it). |
mattrobenolt
force-pushed
the
master
branch
2 times, most recently
from
0ba26c4 to
ae338e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three endpoints missing from interfaces.json added (posts.update, forums.addModerator and forums.removeModerator);
Somewhat cosmetic change: Some API calls (notably posts.create with certain args like ip_address) will not work as expected if both public_key and secret_key are passed, so alter the check in
disqusapi.DisqusAPI.__init__()so that it doesn't complain when only secret key is provided.