Skip to content

Fix: issue #30. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: issue #30. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bitcoin-testscripts/src/bitvm/bigint/add.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ impl<const N_BITS: u32, const LIMB_SIZE: u32> BigIntImpl<N_BITS, LIMB_SIZE> {
/// This function prevents overflow of the underlying integer types during
/// left shift operation.
pub fn lshift_prevent_overflow(bits: u32) -> Script {
if bits == 0 {
script! {}
}
script! {
// stack: {limb}
{ 1 << LIMB_SIZE } // {limb} {base}
Expand Down
16 changes: 10 additions & 6 deletions bitcoin-testscripts/src/bitvm/bigint/bits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,15 @@ pub fn limb_to_le_bits(num_bits: u32) -> Script {
}
}

pub fn limb_to_le_bits_toaltstack(num_bits: u32) -> Script {
pub fn limb_to_le_bits_toaltstack(num_bits: usize) -> Script {
if num_bits >= 2 {
script! {
{ limb_to_le_bits_common(num_bits) }
for _ in 0..num_bits {
OP_TOALTSTACK
}
for _ in 0..num_bits { OP_TOALTSTACK }
}
} else if num_bits == 1 {
script! {
OP_TOALTSTACK
}
} else {
script! {}
Expand All @@ -206,17 +208,19 @@ pub fn limb_to_be_bits(num_bits: u32) -> Script {
}
}

pub fn limb_to_be_bits_toaltstack(num_bits: u32) -> Script {
pub fn limb_to_be_bits_toaltstack(num_bits: usize) -> Script {
if num_bits >= 2 {
script! {
{ limb_to_be_bits_common(num_bits) }
OP_TOALTSTACK
OP_TOALTSTACK
}
} else {
} else if num_bits == 1 {
script! {
OP_TOALTSTACK
}
} else {
script! {}
}
}

Expand Down