Extract sudo calls from bash scripts in bin/#1
Open
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
Open
Extract sudo calls from bash scripts in bin/#1mkuettel wants to merge 1 commit intodiva-exchange:developfrom
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
Conversation
mkuettel
force-pushed
the
extract-sudo
branch
from
a17b95f to
d5d7b59
Compare
Author
|
Confirmed locally that having a user in the docker group and running works: |
On some systems the user I want to run these scripts on are not in the
sudoers group, but might be in the docker group.
Additionally, this is useful to check whether all of these elevated
commands are actually needed.
Using this commit I'm testing this by calling the script setting the
environment variable SUDO_CMD to an empty string. For example:
SUDO_CMD= bin/build.sh
mkuettel
force-pushed
the
extract-sudo
branch
from
d5d7b59 to
c73cd2f
Compare
Author
|
Do you want to merge this? Or should I adjust something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some systems the user I want to run these scripts on are not in the sudoers group, but might be in the docker group.
Additionally, this is useful to check whether all of these elevated commands are actually needed.
Using this commit I'm testing this by calling the script setting the environment variable SUDO_CMD to an empty string. For example:
Not sure if this is anything worthwhile, but here's my branch :)