Open
Conversation
When I first ran the build script I didn't have npm installed but had tsc,
I then got the following error
⇒ Creating diva.yml file…
../../build.ts:20:16 - error TS2307: Cannot find module 'fs' or its corresponding type declarations.
20 import fs from 'fs';
With more similar errors following.
This occured because the node dependencies were not installed.
I therefore installed npm and added an npm install to the script.
We might need to pass further options because we want this scripted
nicely, but for now I propose just adding an npm install call before the
call to the typescript compiler tsc.
Author
|
@diva-exchange do you think this needs to be in there as well? Is this ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I first ran the build script I didn't have npm installed but had tsc, I then got the following error
With more similar errors following.
This occured because the node dependencies were not installed. I therefore installed npm and added an npm install to the script.
We might need to pass further options because we want this scripted nicely, but for now I propose just adding an npm install call before the call to the typescript compiler tsc.