use more verbose syntax for compat with newer docker-compose#3
Draft
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
Draft
use more verbose syntax for compat with newer docker-compose#3mkuettel wants to merge 1 commit intodiva-exchange:developfrom
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
Conversation
When running bin/build.sh and bin/start.sh afterwards with a newer
docker-compose (in my case 2.24.0) it fails to decode the generated
diva.yml file and it seems it wants the more verbose syntax.
⇒ Pulling /home/mogria/Code/diva-packaging/diva-dockerized/build/domains/testnet.local…
Running privileged command
docker compose -f ./diva.yml pull
62 error(s) decoding:
* 'services[explorer.testnet.local].depends_on' expected a map, got 'slice'
* 'services[explorer.testnet.local].ports[0]' expected a map, got 'string'
* 'services[i2p.http.testnet.local].ports[0]' expected a map, got 'string'
* 'services[i2p.http.testnet.local].volumes[0]' expected a map, got 'string'
....
Therefore I adjusted the JavaScript code which generates it to use the
more verbose newer syntax.
Afterwards running bin/build.sh and bin/start.sh works like a charm.
Author
|
This is a draft as I'm not sure wheter I set all the additional keys correctly. Then theres the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running bin/build.sh and bin/start.sh afterwards with a newer docker-compose (in my case 2.24.0) it fails to decode the generated diva.yml file and it seems it wants the more verbose syntax.
Therefore I adjusted the JavaScript code which generates it to use the more verbose newer syntax.
Afterwards running bin/build.sh and bin/start.sh works like a charm.