Skip to content

Comments

use more verbose syntax for compat with newer docker-compose#3

Draft
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
mkuettel:docker-compose
Draft

use more verbose syntax for compat with newer docker-compose#3
mkuettel wants to merge 1 commit intodiva-exchange:developfrom
mkuettel:docker-compose

Conversation

@mkuettel
Copy link

When running bin/build.sh and bin/start.sh afterwards with a newer docker-compose (in my case 2.24.0) it fails to decode the generated diva.yml file and it seems it wants the more verbose syntax.

 ⇒  Pulling /home/mogria/Code/diva-packaging/diva-dockerized/build/domains/testnet.local…
Running privileged command
   docker compose -f ./diva.yml pull
62 error(s) decoding:

* 'services[explorer.testnet.local].depends_on' expected a map, got 'slice'
* 'services[explorer.testnet.local].ports[0]' expected a map, got 'string'
* 'services[i2p.http.testnet.local].ports[0]' expected a map, got 'string'
* 'services[i2p.http.testnet.local].volumes[0]' expected a map, got 'string'

....

Therefore I adjusted the JavaScript code which generates it to use the more verbose newer syntax.

Afterwards running bin/build.sh and bin/start.sh works like a charm.

When running bin/build.sh and bin/start.sh afterwards with a newer
docker-compose (in my case 2.24.0) it fails to decode the generated
diva.yml file and it seems it wants the more verbose syntax.

     ⇒  Pulling /home/mogria/Code/diva-packaging/diva-dockerized/build/domains/testnet.local…
    Running privileged command
       docker compose -f ./diva.yml pull
    62 error(s) decoding:

    * 'services[explorer.testnet.local].depends_on' expected a map, got 'slice'
    * 'services[explorer.testnet.local].ports[0]' expected a map, got 'string'
    * 'services[i2p.http.testnet.local].ports[0]' expected a map, got 'string'
    * 'services[i2p.http.testnet.local].volumes[0]' expected a map, got 'string'

    ....

Therefore I adjusted the JavaScript code which generates it to use the
more verbose newer syntax.

Afterwards running bin/build.sh and bin/start.sh works like a charm.
@mkuettel
Copy link
Author

This is a draft as I'm not sure wheter I set all the additional keys correctly.
In particular theres the protocol: tcp key, but we might also want udp for i2pd. I'm not sure if mode: should be ingress

Then theres the depends_on thing, there are now new possibilities about restarting and those might be duplicate with the keys in the node service definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant