add bin/appimg.sh to build an app image out of i2p and divachain#4
Draft
mkuettel wants to merge 5 commits intodiva-exchange:developfrom
Draft
add bin/appimg.sh to build an app image out of i2p and divachain#4mkuettel wants to merge 5 commits intodiva-exchange:developfrom
mkuettel wants to merge 5 commits intodiva-exchange:developfrom
Conversation
added 5 commits
January 26, 2024 11:54
On some systems the user I want to run these scripts on are not in the
sudoers group, but might be in the docker group.
Additionally, this is useful to check whether all of these elevated
commands are actually needed.
Using this commit I'm testing this by calling the script setting the
environment variable SUDO_CMD to an empty string. For example:
SUDO_CMD= bin/build.sh
This script expects bin/build.sh to have been successfully run and copies the result from the docker build out of the images into the build/exchange.diva.divachain.AppDir/ which is the basis for the build using the appimagetool called at the end of the script. This is done because the same i2p and divachain build process should be used for the app image as well. So in this POC we just use the built binaries of the respecting containers. Because of this we need to resort to binary patching to adjust these binaries for them to be able to be run inside of an AppImage instead a docker container environment. The AppRun script is the entrypoint which gets executed when starting the resulting appimage. The idea is that this script setups up the required data directories required by i2p, starts the i2p daemon & starts divachain. When closing divachain the i2p daemon should be stopped as well.
Author
|
I'm now at the point that i2pd is started in the background in the launch script of the AppImage ( In principle it runs, but I've still packaged packaged some of the shared libraries wrong. |
Owner
|
Solution approach:
as soon as a working divachain binary is available, the appimage build will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script expects bin/build.sh to have been successfully run and copies the result from the docker build out of the images into the build/exchange.diva.divachain.AppDir/
which is the basis for the build using the appimagetool called at the end of the script.
This is done because the same i2p and divachain build process should be used for the app image as well. So in this POC we just use the built binaries of the respecting containers. Because of this we need to resort to binary patching to adjust these binaries for them to be able to be run inside of an AppImage instead a docker container environment.
The AppRun script is the entrypoint which gets executed when starting the resulting appimage.
The idea is that this script setups up the required data directories required by i2p, starts the i2p daemon & starts divachain.
When closing divachain the i2p daemon should be stopped as well.