Skip to content

Fix authentication challenge completion handler not being called #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eli-Liebman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix authentication challenge completion handler not being called #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/NetShears/URLProtocol/NetworkLoggerUrlProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ extension NetworkLoggerUrlProtocol: URLSessionDataDelegate {
func urlSession(_ session: URLSession, didReceive challenge: URLAuthenticationChallenge, completionHandler: @escaping (URLSession.AuthChallengeDisposition, URLCredential?) -> Void) {
let protectionSpace = challenge.protectionSpace
let sender = challenge.sender

if protectionSpace.authenticationMethod == NSURLAuthenticationMethodServerTrust {
if let serverTrust = protectionSpace.serverTrust {
let credential = URLCredential(trust: serverTrust)
Expand All @@ -133,6 +133,9 @@ extension NetworkLoggerUrlProtocol: URLSessionDataDelegate {
return
}
}

sender?.performDefaultHandling?(for: challenge)
completionHandler(.performDefaultHandling, nil)
}

func urlSessionDidFinishEvents(forBackgroundURLSession session: URLSession) {
Expand Down