-
Notifications
You must be signed in to change notification settings - Fork 4
update all CI head to 3.14 prerelease #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI configuration to test against Python 3.14 prerelease instead of Python 3.13. The change ensures CI runs test the latest prerelease version while maintaining compatibility testing with older supported versions.
- Updates all Python version references from '3.13' to '3.14' in CI matrices
- Adds
allow-prereleases: true
to all Python setup steps to enable prerelease installation - Removes the entire release workflow file
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/test.yml | Updates Python version matrices and adds prerelease support for all test jobs |
.github/workflows/release.yml | Completely removes the release workflow |
.github/workflows/lint.yml | Updates Python version matrix and adds prerelease support for linting jobs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Strange that Windows fails on https://github.com/andfoy/pywinpty because their tests pass on Python 3.14 and 3.14t.
|
Perhaps revert the Windows upgrades for now and focus on the one Linux test failure. |
strategy: | ||
matrix: | ||
python-version: ['3.9', '3.13'] | ||
python-version: ['3.9', '3.14'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ['3.9', '3.14'] | |
python-version: ['3.9', '3.13'] |
- python-version: '3.9' | ||
django-version: '5.0' | ||
- python-version: '3.13' | ||
- python-version: '3.14' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- python-version: '3.14' | |
- python-version: '3.13' |
.github/workflows/test.yml
Outdated
python-version: ${{ matrix.python-version }} | ||
allow-prereleases: true | ||
- name: Install latest Rust stable | ||
uses: actions-rs/toolchain@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is really needed? Rust is pre-installed on all GitHub Actions images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/actions-rs/toolchain is an archived repository last modified 5 years ago.
All GitHub Actions have stable Rust pre-installed.
Its failing because pywinpty does not have a binary release for python 3.14 yet. I'll just wait until it does to merge this PR. We can build from source but its not worth it. |
It is useful to have Linux and macOS testing successfully on Py3.14 and add Windows in a separate pull request. |
They have and they are in this PR. This is good enough for me to wait. |
No description provided.