-
Notifications
You must be signed in to change notification settings - Fork 16
Fix file+json data post #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 81.39% 81.48% +0.08%
==========================================
Files 4 4
Lines 129 135 +6
==========================================
+ Hits 105 110 +5
- Misses 24 25 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 81.39% 81.61% +0.22%
==========================================
Files 4 4
Lines 129 136 +7
==========================================
+ Hits 105 111 +6
- Misses 24 25 +1
Continue to review full report at Codecov.
|
|
Hi! Thanks for this pull request! Aside from a small change, this looks ok to merge. |
|
Ok @vdboor, just added a little test. As said above it simulates the |
When posting to a django rest framework model with a file attribute, data is json stringified, so we need to json load it in order to get it.