Skip to content

Issue 244 - update KPI numbers on the website#250

Open
ehemp wants to merge 7 commits intodjangoindia:mainfrom
ehemp:issue_244
Open

Issue 244 - update KPI numbers on the website#250
ehemp wants to merge 7 commits intodjangoindia:mainfrom
ehemp:issue_244

Conversation

@ehemp
Copy link
Copy Markdown

@ehemp ehemp commented Dec 9, 2024 •
edited
Loading

Closes #244 - [UI] update numbers on the website

Created API request to GitHub for Stars and Contributor counts for DataCard.tsx

Changes

  1. Created apiDataCard.ts, configured DataCard count numbers for fetching actual data - Subscribers explicitly set, Contributors & Stars set by API
  2. Edited subtext for Contributors and Stars to be grammatically correct and removed '+'.

Type of change

  • Bug fix
  • Feature update
  • Breaking change
  • Documentation update

Flags

  1. This is my first time contributing to open source. Please message me with code formatting issues that need fixing. I would love any and all feedback as I have never worked on a project with a team.
  2. Also, my first time working with TypeScript.

Demo

DataCardChanges

How has this been tested?

  1. Checked via running web server with Docker and localhost:3000 via chrome browser.

Author Checklist

  • Code has been commented, particularly in hard-to-understand areas
  • Changes generate no new warnings
  • Vital changes have been captured in unit and/or integration tests
  • New and existing unit tests pass locally with my changes
  • Documentation has been extended, if necessary
  • Merging to main from fork:issue_244

Additional context

  1. Please message me with correct formatting. I would like to contribute to a team properly as I am actively searching for a job in this type of field and need real world experience. Any feedback and tips is greatly appreciated, thanks.

ehemp added 6 commits December 8, 2024 14:36
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
ea2aab4 
…count numbers for fetching actual data - Subscribers, Contributors, Stars
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
2ecde32 
…count numbers for fetching actual data - Subscribers, Contributors, Stars
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
fd80817 
…count numbers for fetching actual data - Subscribers, Contributors, Stars
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
c922933 
…count numbers for fetching actual data - Subscribers explicitly set, Contributors & Stars set by API
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
ad239f7 
…count numbers for fetching actual data - Subscribers explicitly set, Contributors & Stars set by API
@ehemp
Fixed djangoindia#244 -- Created apiDataCard.ts, configured DataCard …
94bafdd 
…count numbers for fetching actual data - Subscribers explicitly set, Contributors & Stars set by API. Added comments.
github-actions[bot]
github-actions bot reviewed Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Django India! 🎉🇮🇳

We're so happy to see you contribute. Your efforts mean a lot to us and we're excited to have you on this journey.

Before we proceed, please take a moment to review our contribution guide. It's packed with all the information you need to make your contribution seamless.

If you're fixing an issue from the Django India issue tracker, remember to get it assigned to you before you acutally start working on it.

If you ever need help or just want to chat, the Django India discord server is always open. We're here for you!

And while you're here, don't forget to ⭐ star our repo to show your support! It helps the community grow.

Thank you for being a part of Django India. Together, let's make an amazing community! 🚀

@yanurag-dev
Copy link
Copy Markdown
Contributor

yanurag-dev commented Dec 9, 2024 •
edited
Loading

@ehemp Consider providing a clearer PR title for better understanding.

Saurabhsharma884
Saurabhsharma884 requested changes Dec 15, 2024
View reviewed changes
frontend/src/components/DataCard/apiDataCard.ts Outdated
options: {method: "GET", headers: {'X-GitHub-Api-Version': '2022-11-28'}},
};
export const url = {
stargazers_count: "https://api.github.com/repos/djangoindia/djangoindia.org",
Copy link
Copy Markdown
Collaborator

@Saurabhsharma884 Saurabhsharma884 Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use env for these

@ehemp ehemp requested a review from DevilsAutumn as a code owner January 9, 2025 19:03
ehemp
ehemp commented Jan 9, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@ehemp ehemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added URLs to .env and .env.example and edited apiDataCard.ts to reflect the changes.

@ehemp ehemp changed the title Issue 244 Issue 244 - update KPI numbers on the website Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Saurabhsharma884 Saurabhsharma884 Saurabhsharma884 requested changes

@DevilsAutumn DevilsAutumn Awaiting requested review from DevilsAutumn DevilsAutumn is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UI] update numbers on the website

3 participants

@ehemp @yanurag-dev @Saurabhsharma884