Conversation
|
@DevilsAutumn I have started with this issue. can you pls verify am I on correct path as you wanted to implement this. |
| return self.paginator.get_paginated_response(data) | ||
|
|
||
|
|
||
| class BaseViewSet(TimezoneMixin, ModelViewSet, PaginationMixin): |
There was a problem hiding this comment.
I dont think we need PaginationMixin in because ModelViewSet already has it as an attribute. So, if we simply add pagination_class=None, it will remove the pagination for that viewset.
| permission_classes = [IsAuthenticated] | ||
| permission_classes = [AllowAny] |
There was a problem hiding this comment.
did just for testing purpose
|
Hi @Yadavanurag13 , Can you please rebase this PR on main? |
|
@DevilsAutumn Sure I'll do that. |
|
@DevilsAutumn. I have rebased the pr but there was some finding that I have to address and test it out. Once I'll complete this I'll let u know. |
|
@CodeRabbit fullreview |
|
@Yadavanurag13 I'll conduct a full review of the changes in this PR that adds pagination to the APIs. ✅ Actions performedFull review triggered. |
|
Warning Rate limit exceeded@Yadavanurag13 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 35 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
✨ Finishing touches
🧪 Generate unit tests
Comment |
Closes #315
Type of change
Author Checklist
mainfromfork:branchname