feat: Add model to store background task details#351
Open
Suraj1089 wants to merge 9 commits intodjangoindia:mainfrom
Open
feat: Add model to store background task details#351Suraj1089 wants to merge 9 commits intodjangoindia:mainfrom
Suraj1089 wants to merge 9 commits intodjangoindia:mainfrom
Conversation
DevilsAutumn
requested changes
Mar 30, 2025
Member
DevilsAutumn
left a comment
DevilsAutumn
left a comment
There was a problem hiding this comment.
Thanks @Suraj1089 ! Left few comments.
ankanchanda
reviewed
Mar 30, 2025
ankanchanda
reviewed
Mar 30, 2025
ankanchanda
reviewed
Mar 30, 2025
ankanchanda
reviewed
Mar 30, 2025
Suraj1089
commented
Mar 31, 2025
Contributor
Author
|
@DevilsAutumn @ankanchanda I have addressed your review comments. can you please review it again? |
DevilsAutumn
requested changes
Apr 5, 2025
DevilsAutumn
requested changes
Apr 19, 2025
Member
DevilsAutumn
left a comment
DevilsAutumn
left a comment
There was a problem hiding this comment.
Thanks @Suraj1089 ! Left one minor comment and can we also add it to the db/admin.py so that the logs are accessible from admin panel?
Co-authored-by: Bhuvnesh <bhuvnesh875@gmail.com>
Contributor
Author
|
@DevilsAutumn @ankanchanda I have addressed your review comments. can you please review it again? |
Member
|
Cool! Now lets add the decorator to the following tasks, so that we can track them.
After that, I think it will be ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FEATURE] Create a decorator to record background tasks #328
#328
Type of change
How has this been tested?