Fixed #337 - [UI] Improved attendee count section#355
Open
Alien501 wants to merge 3 commits intodjangoindia:mainfrom
Open
Fixed #337 - [UI] Improved attendee count section#355Alien501 wants to merge 3 commits intodjangoindia:mainfrom
Alien501 wants to merge 3 commits intodjangoindia:mainfrom
Conversation
Saurabhsharma884
assigned
Saurabhsharma884 and
Alien501 and unassigned
Saurabhsharma884
Saurabhsharma884
requested changes
Apr 27, 2025
| </Button> | ||
| </Link> | ||
| )} | ||
| <div className='font-sans'> |
Collaborator
There was a problem hiding this comment.
Do we need this class here ?
| <p className='mb-6 text-gray-700'> | ||
| Registration ends:{' '} | ||
| <span className='font-semibold'> | ||
| {dayjsWithTZ(registration_end_date).format('DD MMMM, YYYY')}{' '} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {dayjsWithTZ(registration_end_date).format('DD MMMM, YYYY')}{' '} | |
| {dayjsWithTZ(registration_end_date).format('DD MMMM, YYYY')} |
|
|
||
| {registration_end_date ? ( | ||
| <p className='mb-6 text-gray-700'> | ||
| Registration ends:{' '} |
Collaborator
There was a problem hiding this comment.
Suggested change
| Registration ends:{' '} | |
| Registration ends: |
|
|
||
| <div | ||
| className='prose prose-lg mb-16 max-w-none text-gray-700' | ||
| dangerouslySetInnerHTML={{ __html: sanitizedDescription }} |
Collaborator
There was a problem hiding this comment.
lets avoid using dangerouslySetInnerHTML
Saurabhsharma884
requested changes
May 11, 2025
Saurabhsharma884
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337
Changes
Type of change
Flags
Demo
How has this been tested?
Author Checklist
mainfromfork:branchnameAdditional context