-
Notifications
You must be signed in to change notification settings - Fork 62
Fix #244: [UI] update numbers on the website #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -95,3 +95,6 @@ For more details, please see our [Contributing.md](https://github.com/djangoindi | |||||
|
|
||||||
| This project is licensed under the MIT License, one of the most permissive and widely used open-source licenses.This means that you can integrate this project into your applications, modify it to fit your needs, and even distribute it as part of a commercial product without any concern for legal restrictions. | ||||||
| For more details, please see our [License.](https://github.com/djangoindia/djangoindia.org/blob/main/LICENSE) | ||||||
|
|
||||||
|
|
||||||
| <!-- Issue #244 addressed --> | ||||||
|
Comment on lines
+99
to
+100
|
||||||
| <!-- Issue #244 addressed --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR claims to fix issue #244 which requests updating the website numbers (contributors to 25+, subscribers to 250+, stars to 100+), but only adds an HTML comment to the README.md file. The actual UI numbers are located in frontend/src/components/DataCard/DataCard.tsx (lines 23, 30, and 37) and already contain the values requested in the issue (25, 250, and 100 respectively). Either these values were already correct and the issue was already resolved, or this PR is incorrectly claiming to fix the issue without making any meaningful changes. The comment added does not serve any functional purpose.