You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
User wants to delete projects, especially on devices with no or limited possibilities to delete files and directories "manually".
The most useful place to do so might be in the project view, because there we probably listened to and looked at the current project, whereas in the main(?) view the user would need to know the projects name in order to delete the correct one.
After deletion from the projects view, the user shall be presented the load/new ("main"?) view.
Findings and pointers so far:
make sure to free that projects/songs/instruments/... memory
there is no 'delete directory' functionality implemented yet
delete directory implementation will differ from platform to platform :(
Description
Thank you for contributing to Little Piggy Tracker!
For fixes, please include a summary of the changes and any related issue.
For features, please include a detailed description of the new feature and how it works.
All PR:s are run through line-by-line clang-format and builds for all supported platforms.
clang-format can be applied locally on commit by installing pre-commit from repo root:
cp pre-commit .git/hooks/
Fixes # (issue)
Type of change
Please delete option that isn't relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions on how to reproduce.
Test Configuration:
Hardware:
OS version:
Checklist:
I have performed a self-review of my code
I have commented particularly in hard-to-understand areas
Hey thanks for making this!
I'm not sure it makes sense having the delete option in the project view, where would you end up when deleting a project when inside a project for instance?
I think having a load screen menu item and/or button combo makes the most sense. :)
Hey thanks for making this! I'm not sure it makes sense having the delete option in the project view, where would you end up when deleting a project when inside a project for instance? I think having a load screen menu item and/or button combo makes the most sense. :)
I certainly think its a bit more difficult to implement. Its the screen where I was searching the functionality, after having played with a track until I deemed it broken. (Brain: "go up, delete, create new"). When one opens the "Load (or new)" screen from there, the selected entry is the last song afaik, that would also work. In the project screen the current projects title is not avaible/visible. I wanted to patch that, but I couldnt figure out where to find the songs title.
Also note that there is no actual deletion code yet - unfortunately that'll need to get implemented per "filesystem".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for #192
Description
User wants to delete projects, especially on devices with no or limited possibilities to delete files and directories "manually".
The most useful place to do so might be in the project view, because there we probably listened to and looked at the current project, whereas in the main(?) view the user would need to know the projects name in order to delete the correct one.
After deletion from the projects view, the user shall be presented the load/new ("main"?) view.
Findings and pointers so far:
Description
Thank you for contributing to Little Piggy Tracker!
For fixes, please include a summary of the changes and any related issue.
For features, please include a detailed description of the new feature and how it works.
All PR:s are run through line-by-line clang-format and builds for all supported platforms.
clang-format can be applied locally on commit by installing pre-commit from repo root:
cp pre-commit .git/hooks/
Fixes # (issue)
Type of change
Please delete option that isn't relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions on how to reproduce.
Test Configuration:
Checklist: