Merged
Conversation
Add view item Pass render mode to MixerService on ProjectView::Update
Notify users when entering and exiting recording
Remove old config-based recording and references in documentation.
[bug] Inconsistency when moving from projectview to songview with recording armed
Notification will show wrong message
[bug] Not disabling recording when exiting causes audio and timing to flip out
Track will play back silently at many times the speed.
Puts the mode in ViewData Respects play mode
Actually render a project when initiating.
viewData_->renderMode_ is neat for keeping common recording state reference between Project/Song
views.
[OK] It's possible to change output mode while rendering but nothing happens.
[OK] Rendering continues to work as intended.
[OK] No problems found when changing mode while rendering then starting with a new mode
Initialize Mixerservice :: isRendering in constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ProjectView Render project item
When in project view, it's now possible to initiate rendering