Skip to content

Move_clipping_to_audiomixer#221

Open
djdiskmachine wants to merge 1 commit intomasterfrom
move_clipping_to_audiomixer
Open

Move_clipping_to_audiomixer#221
djdiskmachine wants to merge 1 commit intomasterfrom
move_clipping_to_audiomixer

Conversation

@djdiskmachine
Copy link
Owner

Not rigorously tested, only baseline for discussion in #173
Moves implementation from AudioOutDriver
Clipping pre rendering

Not rigorously tested, only baseline
Moves implementation from AudioOutDriver
Clipping pre rendering
@purelygrey
Copy link

Nice, thanks! I just found the time to look at this, so far so good, and it does look more appropriate to have it in the mixer. I'll mess with it more and will come back in a few days

@purelygrey
Copy link

I tested the Linux x64 build more and I can confirm FILE and FILERT both go through clipping stage now. I wouldn't change anything in the PR. Noticed a couple of odd things:

  1. Hard clip indicator doesn't show anymore, at least I haven't seen it so far. I've yet to investigate
  2. Sometimes audio stops working seemingly at random. I have a feeling that maybe switching clipping types causes it, not 100% sure yet. There's nothing in logs, might be not related to the PR
  3. FILE and FILERT generate slightly different files. I expected them to be the same but there's some sort of difference or instability going on. I couldn't hear any difference and the files are both of identical size, but the hashes are different and diffing them did yield some difference in bytes. Maybe this is normal, I'm not sure. Probably not related to the PR

@djdiskmachine
Copy link
Owner Author

Great findings!

Hard clip indicator - yes i noticed a while back but I forgot to do anything about it. 😅

Sometimes audio stops working - this has been an issue for quite a while. I'm almost positive this is due to multi threaded audio/midi stuff. This is not there at all on my single core devices but all (RASPI/macos/Linux) multi core devices I've tried on have the issue.

I thought it was a midi specific thing and attempted to fix it using a concurrenqueue implementation but apparently It wasn't the whole story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants