Open
Conversation
This commit protects the midi queue with a basic mutex locker on X64. So far it seems like this keeps midi working, doesn't crash or end up with audio hanging.
Owner
djdiskmachine
left a comment
djdiskmachine
left a comment
There was a problem hiding this comment.
Looks promising, will try it out!
| @@ -105,31 +100,34 @@ void MidiService::Trigger() { | |||
|
|
|||
| #ifndef _FEAT_MIDI_MULTITHREAD | |||
Owner
There was a problem hiding this comment.
Since we removed it from the related makefile, we don't need this anymore?
Or does FEAT_MIDI_MULTITHREAD still serve some role that I'm just not understanding? =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Mutex Locker for midi on X64
This commit protects the midi queue with a basic mutex locker on
X64. So far it seems like this keeps midi working, doesn't crash
or end up with audio hanging.
This is split into 2 commits, the first is just clang format, the best way to view the functional changes is by reviewing the commits individually particularly the second.
Type of change
Fixes Random audio engine crash оn Linux #225
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I tested this for a couple of days on my rg35xx with some additional changes for midi in, (my rg35xx is using a build that is identical to X64)
Test Configuration:
Checklist:
sources/Application/Model/Project.h