Changes on line 257 of main.js to allow modern Minecraft versions to use this tool.#94
Open
AnySpy wants to merge 2 commits intodjfun:masterfrom
Open
Changes on line 257 of main.js to allow modern Minecraft versions to use this tool.#94AnySpy wants to merge 2 commits intodjfun:masterfrom
AnySpy wants to merge 2 commits intodjfun:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detailed in issue #91 by LosVocelos, modern Minecraft versions changed the dimension tag to be a string of "minecraft:[DIM]". Using the old version of a byte is no longer supported and results in the map reading "Unknown Map".
This changed line 257 to create an object that defaults to 'minecraft:overworld' if none is provided in Cookies.get('dimension').
As far as compatibility goes, this may break versions prior to 1.16, according to the Minecraft Wiki page on map NBT.