Fix width on #jenkins-home-link anchor #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Width on `.logo a#jenkins-home-link` ends up with the same of 40px in height and 0px in width, thus making this link useless. This fix extends anchor width to that of `.logo` placeholder div. Link ends up larger than actual image, but I don't know how to elegantly calculate width with only CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Width on
.logo a#jenkins-home-linkends up with the same of 40px in height and 0px in width, thus making this link useless.This fix extends anchor width to that of
.logoplaceholder div. Link ends up larger than actual image, but I don't know how to elegantly calculate width with only CSS.Here is example with fix applied:
