rainier features + cpp funct ptr + barret & clmul reduction + const time inv + fast lagrange precomp + interp + div by x-a#3
Open
shibammukherjee wants to merge 1 commit intodkales:mainfrom
Conversation
…ime inv + fast lagrange precomp + interp + div by x-a
dkales
requested changes
Jun 3, 2022
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wignored-attributes" | ||
| static std::function<uint64_t(__m128i)> reduce; | ||
| static uint64_t (*reduce_naive)(__m128i); |
Owner
There was a problem hiding this comment.
This should probably be only a single function pointer that gets set to the fastest variant for each field size.
| return buffer; | ||
| } | ||
|
|
||
| uint64_t GF2E::get_data() const { return this->data; } |
Owner
There was a problem hiding this comment.
Probably don't want this, if you need access to data in a function like eval, make it a friend function.
| modulus = | ||
| (1ULL << 16) | (1ULL << 5) | (1ULL << 3) | (1ULL << 1) | (1ULL << 0); | ||
| reduce = reduce_GF2_16; | ||
| reduce_naive = reduce_GF2_16; |
Owner
There was a problem hiding this comment.
as mentioned for these, only use the fastest one for each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rainier features + cpp funct ptr + barret & clmul reduction + const time inv + fast lagrange precomp + interp + div by x-a