Open
Conversation
dkales
requested changes
Jun 3, 2022
| return buffer; | ||
| } | ||
|
|
||
| uint64_t GF2E::get_data() const { return this->data; } |
| // normal optmized polynomial evaluation with precomputation optmization | ||
| GF2E eval_fast(const std::vector<GF2E> &poly, const std::vector<GF2E> &x_pow_n, | ||
| const size_t lambda) { | ||
| __m128i acc = _mm_set_epi64x(0, poly[0].get_data()); |
Owner
There was a problem hiding this comment.
Can this not just call dot_product? Then we don't need get_data, and lamda at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast poly eval with precomputation