-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Integrate Sentry #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for comprehensive error tracking and performance monitoring across client and server, including exception capture, profiling, and error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6d7779c7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
server/index.js
Outdated
| // Set up Sentry error handler if DSN is provided | ||
| if (process.env.SENTRY_DSN) { | ||
| Sentry.setupExpressErrorHandler(app); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move Sentry error handler after routes
Express only invokes error-handling middleware that appears after the route/middleware that raised the error, so registering Sentry.setupExpressErrorHandler(app) before any routes means exceptions thrown in /api/instance or static handlers will bypass Sentry and go straight to the default handler. This makes the new error tracking ineffective in production whenever SENTRY_DSN is set. Register the Sentry error handler after all route/static middleware are mounted.
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Retrieve Sentry configuration via a dedicated API endpoint instead of server-side HTML injection.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
for comprehensive error tracking and performance monitoring across client and server, including exception capture, profiling, and error handling.