Fixing unit test issues on tintop master branch#10
Open
ericdscott wants to merge 2 commits intodkmfbk:masterfrom
Open
Fixing unit test issues on tintop master branch#10ericdscott wants to merge 2 commits intodkmfbk:masterfrom
ericdscott wants to merge 2 commits intodkmfbk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the unit tests in the tintop module would not run without fatal errors. Several of the tests appeared to be the work of individual projects pointing to user-specific code, and were removed. Some of the dependencies also pointed at stale resources. There were also a couple of maven declarations that needed adjusting.
I also needed to add symbolic links to the downloaded version point to data models not included in the github code.
Having made these changes, I was then able to step through the code from end to end in Intellij on an Ubuntu system. I edited the docs/download.html file to reflect these changes.