Conversation
Create Python package See merge request switonic-fhnw/ms-eetc-internal!2
Fix a few imports in simulation scripts See merge request switonic-fhnw/ms-eetc-internal!3
dkouzoup
left a comment
dkouzoup
left a comment
There was a problem hiding this comment.
Thanks for the packaging! I just requested a few small changes and we can merge. Please also make sure that all simulations run with the latest version.
| - Activate the virtual environment: `.\.env\Scripts\activate` | ||
|
|
||
| - Install dependencies with: `pip install -r requirements.txt` | ||
| - Install dependencies with: `pip install -e .` |
There was a problem hiding this comment.
Not "dependencies" any more. I would say "Install package" (please also double-check that we indicate the right directory to run the command from).
| @@ -0,0 +1,31 @@ | |||
| from mseetc.train import Train | |||
There was a problem hiding this comment.
Please revert this change and place this code back in ocp.py, as this re-structuring is not relevant for the PR.
| import casadi as ca | ||
|
|
||
| from train import * | ||
| from ..train import * |
There was a problem hiding this comment.
I would - for now - undo the nested ms folder and update the imports (from .track instead of from ..track)
| from track import Track | ||
| from utils import latexify, show, saveFig, postProcessDataFrame | ||
| from efficiency import totalLossesFunction | ||
| from mseetc.ms.ocp import casadiSolver |
There was a problem hiding this comment.
from mseetc.ocp (many occurances)
3 participants
Improved project structure