Skip to content

Conversation

@wilzbach
Copy link
Contributor

Follow-up automation to dlang/phobos#5523

Can be enabled after dlang/phobos#5526

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 29, 2017

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

grep: Unmatched [ or [^

@quickfur
Copy link
Member

Sigh. The shell is interpreting $] because you used double quotes rather than single quotes.

@wilzbach wilzbach force-pushed the check-broken-ddoc branch from 751ace4 to a399264 Compare June 30, 2017 01:04
posix.mak Outdated
@echo "Searching for undefined macros"
@grep -n "UNDEFINED MACRO" $$(find $(DOC_OUTPUT_DIR) -type f -name "*.html" -not -path "$(DOC_OUTPUT_DIR)/phobos/*") ; test $$? -eq 1
@echo "Searching for undefined ddoc"
@grep -rn "[$$](" $(DOC_OUTPUT_DIR)/phobos-prerelease ; test $$? -eq 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "[$](" to '[$](' to fix it.

Copy link
Member

@quickfur quickfur Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure using $$ is the right solution. That may just be another magic variable...
EDIT: nevermind, this fixes it, because it's actually not the shell, but make that interprets it. Sigh...

@JackStouffer
Copy link
Contributor

One would assume that this would be a feature in DMD.

@quickfur
Copy link
Member

File an enhancement request?

@CyberShadow
Copy link
Member

This needs to exclude .verbatim files, as those intentionally consist of DDoc macros.

@wilzbach wilzbach force-pushed the check-broken-ddoc branch 2 times, most recently from 5bddba1 to ee2f825 Compare July 2, 2017 01:02
@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 2, 2017

@CyberShadow - this is finally green & passing :)

@dlang-bot dlang-bot merged commit 0537f51 into dlang:master Jul 2, 2017
@wilzbach wilzbach deleted the check-broken-ddoc branch December 18, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants