-
-
Notifications
You must be signed in to change notification settings - Fork 380
Add check for broken Ddoc #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
3902817 to
751ace4
Compare
|
|
Sigh. The shell is interpreting |
751ace4 to
a399264
Compare
posix.mak
Outdated
| @echo "Searching for undefined macros" | ||
| @grep -n "UNDEFINED MACRO" $$(find $(DOC_OUTPUT_DIR) -type f -name "*.html" -not -path "$(DOC_OUTPUT_DIR)/phobos/*") ; test $$? -eq 1 | ||
| @echo "Searching for undefined ddoc" | ||
| @grep -rn "[$$](" $(DOC_OUTPUT_DIR)/phobos-prerelease ; test $$? -eq 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "[$](" to '[$](' to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure using $$ is the right solution. That may just be another magic variable...
EDIT: nevermind, this fixes it, because it's actually not the shell, but make that interprets it. Sigh...
|
One would assume that this would be a feature in DMD. |
|
File an enhancement request? |
|
This needs to exclude .verbatim files, as those intentionally consist of DDoc macros. |
5bddba1 to
ee2f825
Compare
|
@CyberShadow - this is finally green & passing :) |
Follow-up automation to dlang/phobos#5523
Can be enabled after dlang/phobos#5526