Skip to content

Conversation

@marler8997
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@marler8997 marler8997 force-pushed the includeImports branch 2 times, most recently from 2b171e6 to 50fe839 Compare January 19, 2018 18:03
@marler8997
Copy link
Contributor Author

Pinging @JinShil @wilzbach @timotheecour @ibuclaw (who are the most familiar with dlang/dmd#7099) to review.

@marler8997 marler8997 force-pushed the includeImports branch 5 times, most recently from ac01951 to 1ec77f9 Compare January 19, 2018 22:20
@JinShil
Copy link
Contributor

JinShil commented Jan 19, 2018

We might want to wait until the fate of dlang/dmd#7703 is determined. We're trying to make it so that the documentation all comes from "one source of truth" so we don't have so many inconsistencies between website, man page, and the actual implementation.

@marler8997 marler8997 force-pushed the includeImports branch 2 times, most recently from 0f20135 to b73e461 Compare January 20, 2018 01:36
@marler8997
Copy link
Contributor Author

So do we want to just put this documentation in dmd or is it going to be some time before dlang.org uses that?

@JinShil
Copy link
Contributor

JinShil commented Jan 25, 2018

I think we need one more PR: #2068 Then you should be able to add the documentation to DMD. I suppose you can add it now, but I don't think we'll see the docs rendered until #2068 is in.

@wilzbach
Copy link
Contributor

I suppose you can add it now,

dlang/dmd#7703 has been merged, so you can safely add it to cli.d
You can already see preview the change on the diff for the MAN pages at DAutotest.

but I don't think we'll see the docs rendered until #2068 is in.

#2068 is its final stage, so hopefully it will be merged soon.
In any case, you can just add it to cli.d and it will appear on dlang.org once #2068 is in.

@wilzbach wilzbach closed this Jan 25, 2018
@marler8997
Copy link
Contributor Author

Work moved to dmd PR here (dlang/dmd#7777)

@marler8997 marler8997 deleted the includeImports branch January 25, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants