Use the $(DDOC_BIN) preprocessor with --compiler" #2177
Conversation
wilzbach
requested review from
CyberShadow,
MartinNowak and
andralex
as code owners
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| import std.getopt; | ||
| auto helpInformation = getopt( | ||
| rootArgs, std.getopt.config.passThrough, | ||
| std.getopt.config.required, |
There was a problem hiding this comment.
Config config; is defined above ;-)
| ################################################################################ | ||
|
|
||
| DDOC_BIN:=$G/ddoc | ||
| DDOC_BIN_DMD:=$(DDOC_BIN) --compiler=$(DMD) |
There was a problem hiding this comment.
Not sure where := became a thing in our makefiles. We've kept it for special cases so far.
There was a problem hiding this comment.
Since we started to have ugly, hard-to-trace bugs due accidentally overwritten of variables, see e.g. #1953
wilzbach
force-pushed
the
ddoc-bin
branch
3 times, most recently
from
1caf108 to
7055c53
Compare
|
@ others. FYI: the diff is a bit larger because
|
|
Something weird is happening in |
It's the grammar file and expected (one of the reasons why I made this PR). https://github.com/dlang/dlang.org/blob/master/spec/grammar.dd (I accidentally forgot using the ddoc preprocessor for PDF + Ebook when I made the Grammar generating PR) |
wilzbach
changed the title
4 participants
We always want to use the latest
$(DMD)to build the documentation as-w(Fix Issue 18083 - -w doesn't work for the ddoc build dmd#7440)This makes it more explicit and also adds
$(DDOC_BIN)to a couple of other instances as:(this might produce changes in the verbatim files)