Skip to content

Conversation

@marler8997
Copy link
Contributor

I think this might address the issue with dlang/dmd#7777 but I'm not 100% sure.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escapeDdoc already exists ;-)

@marler8997 marler8997 force-pushed the fixCommasInOptionFlag branch from da4959a to afc9c60 Compare February 7, 2018 20:39
@marler8997
Copy link
Contributor Author

nice...was eerily similar to the new function I added :)

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Sorry that I haven't been able to help you earlier - I was occupied with our Munich Meetup :/

@wilzbach wilzbach merged commit 25696e9 into dlang:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants