Remove PHOBOS macro in favor in REF #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
force-pushed
the
remove-phobos
branch
2 times, most recently
from
ee11fbd to
aeb65c4
Compare
wilzbach
force-pushed
the
remove-phobos
branch
from
aeb65c4 to
4f7885d
Compare
wilzbach
force-pushed
the
remove-phobos
branch
from
4f7885d to
57a1cc6
Compare
Contributor
Author
|
CC @CyberShadow or @ZombineDev - this has been pending for quite a while now (> one month). It's pretty straight-forward... |
CyberShadow
approved these changes
Mar 11, 2018
Member
|
Thanks for the ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the
PHOBOSmacro was a hack to get references to the standard library.We should really use the universal
REFhere.Note - this depends on #2194
edit: this PR has been merged -> this should be good to go.