-
-
Notifications
You must be signed in to change notification settings - Fork 668
error syntax highlighting in func.d #7550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
17fdafc to
138f551
Compare
| * License: $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0) | ||
| * Source: $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/func.d, _func.d) | ||
| * Documentation: https://dlang.org/phobos/dmd_func.html | ||
| * Coverage: https://codecov.io/gh/dlang/dmd/src/master/src/dmd/func.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ddoc's "auto-escaping" rears its head here:
BTW what's the motivation for including Documentation and Coverage on the Ddoc page?
- The user is already on this page
- For Ddox or nightly builds its even a different URL
- Coverage information is not something I expect to be part of the docs?
- If you want something to be done automatic, let us know. It might be more effective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fixed in later versions of dmd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find those links very convenient when editing source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fixed in later versions of dmd.
Oh yes. Actually there's a fix for this setting in the queue for a while already:
I find those links very convenient when editing source code.
I didn't question this, just the fact that you expose them to the user documentation by adding them to the Ddoc header. What was wrong with using // for these two links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You used // Online documentation: <url> or // Coverage: <url> as comments before - this had the advantage of not being displayed on dlang.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I prefer to have them in one Ddoc block.
d9a5f6c to
79c8e10
Compare
79c8e10 to
fdf96cb
Compare

No description provided.