Skip to content

Conversation

@WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@WalterBright WalterBright force-pushed the cannot-deduce branch 3 times, most recently from 17fdafc to 138f551 Compare December 29, 2017 23:37
* License: $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
* Source: $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/func.d, _func.d)
* Documentation: https://dlang.org/phobos/dmd_func.html
* Coverage: https://codecov.io/gh/dlang/dmd/src/master/src/dmd/func.d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ddoc's "auto-escaping" rears its head here:

image

http://dtest.dlang.io/artifact/website-d4a3e415e1933b1bf95375258832afc0fa2d38d9-fee3713e1490cd01808e897fa1057418/web/phobos-prerelease/dmd_func.html

BTW what's the motivation for including Documentation and Coverage on the Ddoc page?

  • The user is already on this page
  • For Ddox or nightly builds its even a different URL
  • Coverage information is not something I expect to be part of the docs?
  • If you want something to be done automatic, let us know. It might be more effective.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fixed in later versions of dmd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find those links very convenient when editing source code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fixed in later versions of dmd.

Oh yes. Actually there's a fix for this setting in the queue for a while already:

#7432

I find those links very convenient when editing source code.

I didn't question this, just the fact that you expose them to the user documentation by adding them to the Ddoc header. What was wrong with using // for these two links?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You used // Online documentation: <url> or // Coverage: <url> as comments before - this had the advantage of not being displayed on dlang.org.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I prefer to have them in one Ddoc block.

@WalterBright WalterBright force-pushed the cannot-deduce branch 5 times, most recently from d9a5f6c to 79c8e10 Compare December 30, 2017 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants