Fix Issue 17625 - Confusing error message for private functions in different modules

[RazvanN7]

The problem was that whenever a symbol is searched in different modules if the same symbol is found in 2 or more different modules an overload set is created no matter the privacy attribute of the symbol. I added a check to make sure that the symbol found is accessible, however that made it so that some deprecations where not issued anymore on some fail_compilation tests. I deleted the tests since it wasn't possible to modify them to get rid of the deprecation. I don't know what the purpose of those tests was, but with the new patch the code does not deprecate anymore. Ideas?

[dlang-bot]

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close	Bugzilla	Description
✓	17625	Confusing error message for private functions in different modules

[wilzbach]

Thou shalt not delete existing tests 👿

If they really pass now, they should be moved to compilable.

[wilzbach]

.

[marler8997]

FYI: You are importing the modules using imports.a17625 but then you declare the module name in the file to be a17625. I'm hoping to deprecate this via #7778