Skip to content

Conversation

@RazvanN7
Copy link
Contributor

Introduced by [1]. The check for disabled should only be made for NewDeclarations, for all other functions that is being taken care of before.

[1] #8042

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 22, 2018

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19419 regression [REG2.080.1] @disabled this() will print wrong error if calling non-default constructor with wrong parameters

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#8994"

@RazvanN7 RazvanN7 changed the title Issue 19419 - [REG2.080.1] @disabled this() will print wrong error if calling non-default constructor with wrong parameters Fix Issue 19419 - [REG2.080.1] @disabled this() will print wrong error if calling non-default constructor with wrong parameters Nov 22, 2018
…r if calling non-default constructor with wrong parameters
@RazvanN7 RazvanN7 changed the base branch from master to stable November 22, 2018 13:51
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Nov 22, 2018

Looks like it's the same old issue with stable and C++ namespace; unrelated to this PR.

@thewilsonator
Copy link
Contributor

Hmm, bummer.

@RazvanN7
Copy link
Contributor Author

We can force push it, just like: #8951

@thewilsonator
Copy link
Contributor

OK (I'm going to sleep soon).

@RazvanN7 RazvanN7 merged commit 579dc9d into dlang:stable Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants