Skip to content

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Apr 3, 2019

Followup to #7767

Hex strings were deprecated in 2.079. Following typical deprecation proceedings, the deprecation warning should now become an error.

Documentation update: dlang/dlang.org#2617

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9549"

@JinShil
Copy link
Contributor Author

JinShil commented Apr 4, 2019

Ocean 5.0.0 was released. Why doesn't buildkite succeed?

cc @mihails-strasuns

@PetarKirov
Copy link
Member

[..]
./src/ocean/transition.d(42): Error: basic type expected, not `static`
--
  | ./src/ocean/transition.d(42): Error: found `static` when expecting `)`
  | ./src/ocean/transition.d(42): Error: semicolon expected following auto declaration, not `immutable`
  | ./src/ocean/transition.d(42): Error: declaration expected, not `)`
  | ./src/ocean/meta/types/Qualifiers.d(73): Error: basic type expected, not `static`
  | ./src/ocean/meta/types/Qualifiers.d(73): Error: found `static` when expecting `)`
  | ./src/ocean/meta/types/Qualifiers.d(73): Error: found `immutable` when expecting `)`
  | ./src/ocean/meta/types/Qualifiers.d(73): Error: found `)` when expecting `;`
  | ./src/ocean/meta/types/Qualifiers.d(73): Error: found `)` instead of statement
  | ./src/ocean/meta/types/Qualifiers.d(169): Error: basic type expected, not `static`
  | ./src/ocean/meta/types/Qualifiers.d(169): Error: found `static` when expecting `)`
  | ./src/ocean/meta/types/Qualifiers.d(169): Error: found `immutable` when expecting `)`
  | ./src/ocean/meta/types/Qualifiers.d(169): Error: no identifier for declarator `U`
  | ./src/ocean/meta/types/Qualifiers.d(169): Error: declaration expected, not `)`
  | ./src/ocean/meta/types/Qualifiers.d(173): Error: declaration expected, not `else`
  | ./src/ocean/meta/types/Qualifiers.d(176): Error: unrecognized declaration
  | ./src/ocean/core/Test.d(230): Error: semicolon expected following function declaration
  | ./src/ocean/core/Test.d(232): Error: declaration expected, not `if`

Looks like an error with the D1 to D2 transition support code.
Also CC @leandro-lucarella-sociomantic @mathias-lang-sociomantic @nemanja-boric-sociomantic.

@Geod24
Copy link
Member

Geod24 commented Apr 5, 2019

Fix for ocean: dlang/ci#381

@mihails-strasuns
Copy link

Why doesn't buildkite succeed?

Starting with 5.0.0 support of D1 was dropped and it doesn't need to run auto-conversion anymore.

@mihails-strasuns
Copy link

Yeah, exactly what @Geod24 has just done :)

@dlang-bot dlang-bot merged commit 4a85f57 into dlang:master Apr 5, 2019
@JinShil JinShil deleted the hex_string_error branch April 16, 2019 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants