Skip to content

Conversation

@George-Alex-Berea
Copy link
Contributor

Also added these flags to all the functons it calls.
In order to make the functions safe I isolated the 'unsafe' parts inside @trusted lambda expressions, inspired by edi33416's pull request #6416.
Additionally, added nothrow @nogc @safe to the allocateAll function, since it only calls allocate.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @George-Alex-Berea! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10780"

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edi33416 if you remember any of this from ages ago, please add your review as it revives your work.

@George-Alex-Berea
Copy link
Contributor Author

@andralex can you please take a look?

@andralex
Copy link
Member

looking good!

@George-Alex-Berea
Copy link
Contributor Author

Should something more be done to get this PR merged?

@thewilsonator
Copy link
Contributor

No, I just need to take a good close look at those @trusted functions

@George-Alex-Berea
Copy link
Contributor Author

Ok, thanks!

@thewilsonator
Copy link
Contributor

CC @teodutu please re-review

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking fine now. Thanks @George-Alex-Berea.

@thewilsonator thewilsonator merged commit aef5fca into dlang:master Jul 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants