Skip to content

Conversation

@growlercab
Copy link
Contributor

Removes ambiguity between min element value and index of min element value.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 15, 2018

Thanks for your pull request, @growlercab! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@wilzbach
Copy link
Contributor

Rebased your PR to stable, s.t. it will be deployed to dlang.org soon.

@MartinNowak
Copy link
Member

CyberShadow/DAutoTest

That one really needs a rerun button @CyberShadow.

@wilzbach
Copy link
Contributor

wilzbach commented Jan 16, 2018

That one really needs a rerun button @CyberShadow.

FYI: The failure is due to the DUB registry being unreachable.
Should I cherry-pick the fix from master to stable? dlang/dlang.org#1926 and dlang/dlang.org#1891

Minor change to minElement example to remove ambiguity between min element value and min element index.
@MartinNowak
Copy link
Member

MartinNowak commented Jan 16, 2018

Should I cherry-pick the fix from master to stable? dlang/dlang.org#1926 and dlang/dlang.org#1891

Yes

@wilzbach
Copy link
Contributor

Should I cherry-pick the fix from master to stable? dlang/dlang.org#1926 and dlang/dlang.org#1891

dlang/dlang.org#2089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants