Skip to content

Add 'RESTRICTION' to valid datatypes#18

Open
SimonGreenhill wants to merge 1 commit intomainfrom
SimonGreenhill-patch-1
Open

Add 'RESTRICTION' to valid datatypes#18
SimonGreenhill wants to merge 1 commit intomainfrom
SimonGreenhill-patch-1

Conversation

@SimonGreenhill
Copy link

In the good old days, for certain analyses, MrBayes wanted the nexus datatype for a characters block to be 'RESTRICTION' (i.e. https://en.wikipedia.org/wiki/Restriction_fragment_length_polymorphism). This datatype is identical to datatype ='STANDARD'

@xrotwang
Copy link
Contributor

Since the datatype is referred to from other places in the code, e.g.

if subcommand == 'DATATYPE' and self.datatype.upper() != 'STANDARD':
self.symbols = []
I'm not sure just adding it as valid choice in one place is the right thing to do. Since it isn't mentioned in the nexus spec, I'd lean towards recommending to replace RESTRICTION with STANDARD in a pre-processing step.

Copy link
Contributor

@xrotwang xrotwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants