Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
The contents seem reasonable.
But, if this is fixing CI testing on the 8.3 branch... shouldn't the CI testing pass?
(The test failures look as though the STATIC label is not being defined in these builds, somehow.)
github-actions
bot
added
public build running
private build failed
public build failed
and removed
private build running
public build running
labels
bjohnsto
changed the title
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
Contingent on CI passing after the changes to main are in, this looks good.
github-actions
bot
added
untested
public build running
public build done
public testing running
public testing done
private build running
and removed
private build failed
public build failed
untested
public build running
public testing running
public testing done
public build done
labels
ScriptFramework.pm causes an error in F41 with the following warning: Name "main::log" used only once: possible typo at ./ScriptFramework.pm line 169. Turn off used only once warning. Signed-off-by: Chung Chung <cchung@redhat.com>
Update branch Makefiles to run 8.3 branch testing by default on RHEL10 machines. Due to the nature of pull_request_target, CI changes for this branch must be made on the main branch. There is a separate PR for that work. Specific branch changes only require the test and test suite changes. Signed-off-by: Bruce Johnston <bjohnsto@redhat.com>
I've updated the PR. |
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
I might have liked a bit more documentation on what you've done here.
For instance, the 'use once' fix appears to be cherry-picked from somewhere else, which is fine, but it would be good for this PR to cite where it came from.
But the content looks basically correct and it's now passing CI, so this is good.
3 participants
Update the the test Makefiles to run 8.3 branch on RHEL10 machines.
This PR needs to wait on #430 to be done first as it requires an 8.3 CI file to exist on the main branch.