Update RHEL 10 version macros for bio_inline_vecs compatibility#431
Merged
C2Redhat merged 1 commit intodm-vdo:mainfrom Mar 10, 2026
Merged
Update RHEL 10 version macros for bio_inline_vecs compatibility#431C2Redhat merged 1 commit intodm-vdo:mainfrom
C2Redhat merged 1 commit intodm-vdo:mainfrom
Conversation
Member
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
The change looks reasonable.
Two questions, though:
-
Please mention the code change affected by the #ifdef change in the title of the PR. When searching through old PR's it is very helpful to see at a glance whether his has to do with bio_io_vecs or from_timer or whatever other change.
-
If this hasn't been backported yet, it seem like there's a good chance it never will be. Is it worth changing the range to be "<= 10.9", or something more expansive?
github-actions
bot
added
public testing done
and removed
public testing running
private testing running
labels
This PR updates the RHEL 10 version comparison macro from 10.2 to 10.9. The bio_inline_vecs interface, originally introduced in Fedora 6.18, has not been backported to RHEL 10.3. Current tracking indicates that a backport is unlikely for the remainder of the RHEL 10 lifecycle. Increasing the macro boundary to 10.9 ensures that the legacy code path remains active for all currently planned RHEL 10 minor releases, preventing build failures as the distro evolves. Please refer to commit 43b3afa for initial request. Signed-off-by: Chung Chung <cchung@redhat.com>
lorelei-sakai
approved these changes
Mar 10, 2026
Member
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
The commit message is very good. Just be sure to update the PR title to match the commit title as well.
C2Redhat
changed the title
github-actions
bot
added
public testing done
private testing done
and removed
public testing running
private testing running
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the RHEL 10 version comparison macro from 10.2 to 10.9.
The bio_inline_vecs interface, originally introduced in Fedora 6.18, has
not been backported to RHEL 10.3. Current tracking indicates that a backport
is unlikely for the remainder of the RHEL 10 lifecycle. Increasing the macro
boundary to 10.9 ensures that the legacy code path remains active for all
currently planned RHEL 10 minor releases, preventing build failures as the
distro evolves.
Please refer to commit 43b3afa for
initial request.