Refactor bio inline vector access for the latest RHEL 10.3 compatibility#434
Refactor bio inline vector access for the latest RHEL 10.3 compatibility#434C2Redhat merged 1 commit intodm-vdo:8.3from
Conversation
github-actions
bot
added
untested
private build running
public build running
public build done
public testing running
public testing done
private build done
private testing running
private testing done
and removed
untested
public build running
public testing running
private build running
private testing running
labels
There was a problem hiding this comment.
The code changes look correct, so that part's good.
For the commit message, when I mentioned referring to the older commits, I was looking for a reference to commit 4f35ffb, the one that added this same code to the main branch. Or better yet, a reference to PR 339, the PR that includes that commit. (I ended up looking them up myself with 'git blame').
The commit messages you do cite only change the #ifdefs, so they're not useful in understanding this change.
Also, I would use a different word than 'refactor' here. To me at least, 'refactoring' means changing the code in such a way that the functionality doesn't change. The last sentence of the commit message is good.
You could say something like "Update 8.3 branch to be compatible with backported kernel changes", or "Merge to RHEL 10 branch".
This PR introduces the bio_inline_vecs macro and update existing instances of bio->bi_io_vec to utilize this interface. The bio_inline_vecs interface was originally introduced in the upstream 6.18 kernel and has officially been backported to RHEL 10.3. This update ensures our driver remains compatible with the backported block layer changes in the RHEL latest 10.3 release. Please refer to commit 4f35ffb or dm-vdo#339. Signed-off-by: Chung Chung <cchung@redhat.com>
lorelei-sakai
left a comment
lorelei-sakai
left a comment
There was a problem hiding this comment.
Thank you for updating. This looks good.
You should also update the PR description to match the changes in the commit message, but that doesn't block merging so I'll approve this.
2 participants
This PR introduces the bio_inline_vecs macro and refactors existing instances of bio->bi_io_vec to utilize this interface.
The bio_inline_vecs interface was originally introduced in the upstream 6.18 kernel and has officially been backported to RHEL 10.3. This update ensures our driver remains compatible with the backported block layer changes in the RHEL latest 10.3 release.
Please refer to commit ea0f08e and d52ee0b previous request.