-
Notifications
You must be signed in to change notification settings - Fork 35
My solution #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agarkovand
wants to merge
9
commits into
dmdev2020:master
Choose a base branch
from
agarkovand:my_solution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
My solution #8
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
edb5b28
added homework
dmdev2020 b011cb1
added homework
dmdev2020 9e4e5a4
Unit Test for parse(date) added
agarkovand 9672d3f
Unit Test for parse(date) added (Invalid date case)
agarkovand 5253adb
Parameterized Unit Test for isValid(date)
agarkovand a9b6f3c
Unit Tests for CreateUserValidator
agarkovand 960a619
Unit Test for CreateUserMapper
agarkovand 544ed6f
Merge branch 'homework' into my_solution
agarkovand 9d18f5c
Fixes after merge
agarkovand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,25 @@ | ||
| package com.dmdev.dao; | ||
|
|
||
| import com.dmdev.entity.BaseEntity; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public interface Dao<K, T> { | ||
| public interface Dao<K, T extends BaseEntity<K>> { | ||
|
|
||
| default T upsert(T entity) { | ||
| return entity.getId() != null | ||
| ? update(entity) | ||
| : insert(entity); | ||
| } | ||
|
|
||
| List<T> findAll(); | ||
|
|
||
| Optional<T> findById(K id); | ||
|
|
||
| boolean delete(K id); | ||
|
|
||
| void update(T entity); | ||
| T update(T entity); | ||
|
|
||
| T save(T entity); | ||
| T insert(T entity); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package com.dmdev.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Value; | ||
|
|
||
| import java.time.Instant; | ||
|
|
||
| @Value | ||
| @Builder | ||
| public class CreateSubscriptionDto { | ||
| Integer userId; | ||
| String name; | ||
| String provider; | ||
| Instant expirationDate; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,4 @@ public class CreateUserDto { | |
| String password; | ||
| String role; | ||
| String gender; | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.dmdev.entity; | ||
|
|
||
| public interface BaseEntity<K> { | ||
|
|
||
| K getId(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.dmdev.entity; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.Optional; | ||
|
|
||
| public enum Provider { | ||
| GOOGLE, APPLE; | ||
|
|
||
| public static Provider findByName(String name) { | ||
| return findByNameOpt(name).orElseThrow(); | ||
| } | ||
|
|
||
| public static Optional<Provider> findByNameOpt(String name) { | ||
| return Arrays.stream(values()) | ||
| .filter(provider -> provider.name().equalsIgnoreCase(name)) | ||
| .findFirst(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,4 @@ public static Optional<Role> find(String role) { | |
| .filter(it -> it.name().equals(role)) | ||
| .findFirst(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.dmdev.entity; | ||
|
|
||
| public enum Status { | ||
| ACTIVE, CANCELED, EXPIRED | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ты не оттуда отбранчевался
домашка по Subscription таблице