Refactor, information tab now separate widget#15
Open
petergarnaes wants to merge 1 commit intomasterfrom
Open
Conversation
The information UI config and code now lives in its own python module. This is the first step in refactoring the main dialog code, and separating out the code and UI config for each of the tabs. This will improve separations of concern in the codebase, and improve readability. Eventually run code (the code extracting data and importing it into QGIS layers) for each of the tabs will live in the module of that tab. The dialog class then simply becomes a controller of the tabs, relaying the run operations. This will impose some much needed structure of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The information UI config and code now lives in its own python module.
This is the first step in refactoring the main dialog code, and
separating out the code and UI config for each of the tabs. This will
improve separations of concern in the codebase, and improve readability.
Eventually run code (the code extracting data and importing it into QGIS
layers) for each of the tabs will live in the module of that tab. The
dialog class then simply becomes a controller of the tabs, relaying the
run operations.
This will impose some much needed structure of the code.