Rewrite station tab run, no pandas, using api module#20
Open
petergarnaes wants to merge 7 commits intomasterfrom
Open
Rewrite station tab run, no pandas, using api module#20petergarnaes wants to merge 7 commits intomasterfrom
petergarnaes wants to merge 7 commits intomasterfrom
Conversation
This is the first part of removing the pandas dependency from this plugin. Also uses the api module for fetching stations. Minor boyscout rule things as well.
petergarnaes
requested review from
allanfrankwork and
svend1079
and removed request for
allanfrankwork and
svend1079
Contributor
|
👍 I'm a bit too unfamiliar with code base to give proper review, but readability seems to have improved. Good to see new types. |
allanfrankwork
approved these changes
Oct 7, 2022
Collaborator
Author
this change does not remove all references to pandas in the |
QGIS does not integrate with the python datetime library, so when creating attributes the input must be basic types: str, int, float. It is possible to make a field a datetime field, but the attribute must a string version of that field. Using ISO formatted datetime strings works.
It is now possible to get stations having any of the given parameters
Some stations, like oceanObs stations does not have barometer height.
OceanObs does not have these attributes
The API for retrieving stations expected datetime objects, but strings were passed. Datetime objects are no passed as expected. Moved the format template string for ISO datetime using Zulu time to a new util module. Other utility values/functions/etc. might move in there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of removing the pandas dependency from this plugin
Also uses the api module for fetching stations
Minor boyscout rule things as well