Handle NaN losses as a consequence of missing data (also in DDP mode)#8
Draft
observingClouds wants to merge 1 commit intomainfrom
Draft
Handle NaN losses as a consequence of missing data (also in DDP mode)#8observingClouds wants to merge 1 commit intomainfrom
observingClouds wants to merge 1 commit intomainfrom
Conversation
|
Nice hack! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR enables to run the training and evaluation also on data containing NaN, by setting the loss rate to None and communicate this across all nodes, i.e. in DDP mode.
While this PR seems to work, it requires to adjust the pytorch-lightning package slightly, by removing the following code 😬
https://github.com/Lightning-AI/pytorch-lightning/blob/df5dee674243e124a2bf34d9975dd586ff008d4b/src/lightning/pytorch/loops/optimization/automatic.py#L322-L327
🥷
Issue Link
< Link to the relevant issue or task. > (e.g.
closes #00orsolves #00)Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee