Open
Conversation
The current implementation forces Transient to be loaded at startup (when reading the generated autoloads file). This is not a sane default since the user can prefer to load the `transient` package only when needed.
The functions `treesit-jump--query-select-*` are marked as interactive (visible in `M-x`), however, they don't have any actual benefit for the user.
`treesit-jump` can work without `gptel`, it doesn't **depend** on it, but it can extend it when using the `treesit-jump-gptel-describe`. This makes the `gptel` optional, if the user doesn't have it (or don't want to), the package should still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for the package!
This PR introduce some improvements:
transientpackage only when needed.treesit-jump--query-select-*are marked as interactive (visible inM-x), however, they don't have any actual benefit for the user.treesit-jumpcan work withoutgptel, it doesn't depend on it, but it can extend it when using thetreesit-jump-gptel-describe. This makes thegpteloptional, if the user doesn't have it (or don't want to), the package should still work.