GMT offset fix #27
Open
GMT offset fix #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2015 20:30
tz_shift(_, "UTC") returns 0, but fmt_shift/1 previously did not handle
that. An alternative fix would be for tz_shift(_, "UTC") to return
{'+', 0, 0}.
Previouly when offset_minute's argument was just digits (for example, "+2" instead of "+2:00"), the argument was incorrectly interpreted as minutes when it should be as hours.
Worked around 2015 Uraguay problem by allowing database to be generated for 2016 instead (with "make DATE=2016-01-01").
|
Well, the database is still not correct, the clock in GMT+X zone faster than GMT+0, so for example GMT+8 should plus 480 minutes not minus. see commit: dhull@b36ea2c |
|
@jacktang I do believe you're right, good sir! Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the GMT+H and GMT-H entries in tz_database.hrl, in which the UTC offset was too small by a factor of 60. The tz-erl script had a bug in the
offset_minutesfunction where it treated an offset that was a plain integer as the offset in minutes instead of hours. (Most entries use "HH:MM" or "0".)Update
fmt_shiftto handle an argument of0. This is necessary fortz_shift/3, becausetz_shift(_, "UTC")return0instead of{+, 0, 0}, and this can cause a problem when usingtz_shift/3to convert to or from UTC.In tz-erl, made the future date test in zone lines more precise.
In tz-erl, better documented the problem with zone that begin or end using DST in the current year. (But did not solve the problem. This happened in Uruguay in 2015.)