Feature ignore domain #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change "getServerName" to "getHttpHost" in order to get the full domain of the request.
Fix method to get the request domain
Owner
|
Hi @SparoHawk thanks for helping us out. I just have a question, why would you want to ignore a domain? Are you running a single instance of phalcon api in multi domains? |
Author
|
@dmkit Thanks for asking. We have an API being consumed by several clients, some of which need access without a JWT token. We are white listing domains consuming the API, not where the API is being hosted. |
Owner
|
@SparoHawk oh I see. Could you please add a unit test please? |
Author
|
@dmkit Will do. |
Contributor
|
@SparoHawk remember we need to add unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.