Open
Conversation
OGKevin
force-pushed
the
fix/host-normalization
branch
from
bac0bbc to
568b12a
Compare
Extract protocol and path stripping logic into a reusable normalize_host() function. This ensures consistent host handling across platform detection, GitHub, and GitLab auth flows, enabling proper support for enterprise instances with full URLs. This is needed as tools like glab work with GITLAB_HOST set to https://gitlab.company.com. - Add normalize_host() function to types module - Update platform detection to normalize hosts - Update GitHub/GitLab services to normalize hosts - Add unit tests for normalization Change-Id: f3759a0d5d8eed4308b5f1100b6adea7 Change-Id-Short: kwsuqpzmumrl
OGKevin
force-pushed
the
fix/host-normalization
branch
from
568b12a to
e37b6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract protocol and path stripping logic into a
reusable normalize_host() function. This ensures
consistent host handling across platform detection, GitHub, and GitLab auth flows, enabling proper
support for enterprise instances with full URLs.
This is needed as tools like glab work with GITLAB_HOST set to
https://gitlab.company.com.Change-Id: f3759a0d5d8eed4308b5f1100b6adea7
Change-Id-Short: kwsuqpzmumrl